Add possibility to establish SSL connection with SSL_VERIFY_NONE

redis / hiredis-rb

Ruby wrapper for hiredis

BSD 3-Clause "New" or "Revised" License

319 stars 90 forks source link

Add possibility to establish SSL connection with SSL_VERIFY_NONE #72

Closed mtuleika-appcast closed 8 months ago

mtuleika-appcast commented 3 years ago

This PR adds possibility to establish SSL connection to Redis with SSL_VERIFY_NONE(in my case to ElastiCache).

What was done:

hiredis submodule was bumped to version 1.0.0
C extension in hiredis-rb was extended to support SSL connection without certification

require 'hiredis'

conn = Hiredis::Connection.new
conn.connect_ssl('<host>', 6379)

conn.write %w[AUTH <password>]
puts conn.read
conn.write %w[SET speed awesome]
puts conn.read
conn.write %w[GET speed]
puts conn.read

ssinghi commented 2 years ago

I think first PR #69 can be merged and then the ssl support added.

milieu commented 2 years ago

Well PR #69 has been merged...

ayoul3 commented 2 years ago

hey @ssinghi and team, would love for this to be merged if/when possible !

engwan commented 2 years ago

@stanhu I also saw https://github.com/michael-grunder/hiredis-rb/commits/ssl-support which is also an attempt to add SSL support.

I saw it has some code to conditionally link OpenSSL: https://github.com/michael-grunder/hiredis-rb/commit/a9897ec9f97cced27e0ba3d4700d7fe638635161#diff-573a6b1ffeebb872ab4255105affc087786e9e64b583ebcf28bca619c0a1227aR48-R49

YegorZdanovich commented 1 year ago

@stanhu @ssinghi @mtuleika-appcast doesn't work on ruby projects anymore, maybe someone can continue this PR