redis / hiredis

Minimalistic C client for Redis >= 1.2
BSD 3-Clause "New" or "Revised" License
6.25k stars 1.82k forks source link

Proposal for CHANGES change #1207

Open chayim opened 1 year ago

chayim commented 1 year ago

Given how we now handle CHANGES< and using the release-drafter, we have a chicken and egg issue. The release drafter handles our release notes now. But the merge for a VERSION is responsible for updating the CHANGES file. We can continue to manually update the CHANGES file prior to release, but that's less than ideal. We can ask/continue to ask the community to update the CHANGES file, but that's a different barrier to entry.

Proposal:

Downside

@yossigo @michael-grunder WDYT?

chayim commented 1 year ago

@uglide WDYT?

michael-grunder commented 1 year ago

This seems reasonable to me.

I don't mind merges directly to master if it isn't changing any code.

chayim commented 1 year ago

The only kicker is that means master git log is polluted with 'UPDATING CHANGES' type merges. The flip side is that we tried doing this in branches elsewhere, as parts of PRs - and frankly it makes merging awful (almost always a conflict, due to multiple merges). Still - I'm pro

chayim commented 1 year ago

@dvora-h so that you see this