redis / hiredis

Minimalistic C client for Redis >= 1.2

BSD 3-Clause "New" or "Revised" License

6.15k stars 1.8k forks source link

#1231 Resolve #1232

Open kendamaskareivis opened 9 months ago

kendamaskareivis commented 9 months ago

See #1231

Changes

change in hiredis.h headers
changes in Cmakelists.txt file

michael-grunder commented 9 months ago

Thanks for the PR. This does improve things in terms of CMake.

The only issue I see is that the change removes any distinction between v1.2.0 proper and the prerelease development branch.

Also the reason we're creating v1.1.0 for v1.2.0 is that v1.2.0 is still API/ABI compatible with v1.1.0 and we were avoiding breaking changes for existing users of v1.1.0

kendamaskareivis commented 9 months ago

Forgive me if I'm in the wrong here @michael-grunder , but it seems silly to me that feature updates are actually breaking changes, something to me doesn't add up here. Well anyway, I'd hope you'll reconsider this PR.

michael-grunder commented 9 months ago

Appologies if I wasn't clear, but I will try to get this merged :smile:

I just need to make sure we don't break existing code is all.

The hiredis SONAME has been a bit of a sticking point for legacy reasons. You can read some of the discussion around this here.