Add support of RESP3 attribute type

redis / hiredis

Minimalistic C client for Redis >= 1.2

BSD 3-Clause "New" or "Revised" License

6.22k stars 1.81k forks source link

Add support of RESP3 attribute type #1248

Closed git-hulk closed 8 months ago

git-hulk commented 8 months ago

Currently, Redis DEBUG PROTOCOL 'attrib' command will return an attribute type, but hiredis doesn't support it yet. So it got the protocol type error:

127.0.0.1:6379>  DEBUG PROTOCOL attrib
Error: Protocol error, got "|" as reply type byte

After apply this PR, it should reply:

127.0.0.1:6379> DEBUG PROTOCOL attrib
1# "key-popularity"
1# 1) "key:123"
   2) (integer) 90

git-hulk commented 8 months ago

redis-cli also doesn't support the RESP3 attribute type yet. I can submit a PR after this patch is merged and updated in redis repository.

git-hulk commented 8 months ago

Hi @michael-grunder Thanks for your review. All review comments are resolved, please retake a look while you're free, thank you!

michael-grunder commented 8 months ago

Merged, thanks!