search

redis / hiredis

Minimalistic C client for Redis >= 1.2
BSD 3-Clause "New" or "Revised" License
6.15k stars 1.8k forks source link

hiredis-test run error #1265

Closed 20072330 closed 2 weeks ago

20072330 commented 2 weeks ago

when run test_resp3_push_handler function，if set redisSetPushCallback， RESP3 PUSH received at next call redisCommand

1718354347408 1718354370431

bjosv commented 2 weeks ago

This seem to work fine in CI, where there are some different jobs that runs on windows, like: https://github.com/redis/hiredis/actions/runs/8540919275/job/23399070664#step:10:84 https://github.com/redis/hiredis/actions/runs/8540919275/job/23399070998#step:6:136

Have you spot any difference compared to these runs?

20072330 commented 2 weeks ago

@bjosv Thanks for your answer. This problem was caused by my negligence.I used hiredis in the deps in the redis source code to do the test, which is inconsistent with the code on the github master branch. 1718373113676

michael-grunder commented 2 weeks ago

So can this issue be closed then?