search

redis / jedis

Redis Java client
MIT License
11.7k stars 3.85k forks source link

Could GSON be optional? / Jackson support? #2961

Open sebdehne opened 2 years ago

sebdehne commented 2 years ago

I really appreciate the good work which has good into this excellent library, but does Jedis really need GSON for JSON-support?

For example there is a security issue with GSON (https://github.com/google/gson/pull/1991) which now becomes everybodies problem who uses Jedis. Would it be possible to at least make GSON optional such that Jedis still works even without GSON on the classpath? Or support both Jackson and GSON (which ever is found on the classpath) if one really needs the JSON capabilities?

Thanks a lot. If you need help - I can submit a change which makes gson optional.

sazzad16 commented 2 years ago

can submit a change which makes gson optional.

@sebdehne You're always welcome to craft a PR.

sazzad16 commented 1 year ago

@sebdehne Sorry about slow progress on this.

WDYT about replacing Gson completely with Jackson?

sazzad16 commented 1 year ago

Thanks to #3223, GSON can now be excluded.

Keeping this issue open as the dependency is not exactly optional.

github-actions[bot] commented 1 month ago

This issue is marked stale. It will be closed in 30 days if it is not updated.