Add support for SPUBLISH #2757

manish-manghwani commented 3 months ago

implementation for #2757

Due to its similarity with PUBLISH and PUBSUB SHARDCHANNELS command, implementation is done in same way. Test cases are not covered, can anyone give guidance on what all test cases should be covered for SPUBLISH Command.

Make sure that:

[x] You have read the contribution guidelines.
[x] You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
[x] You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
[ ] You submit test cases (unit or integration tests) that back your changes.

mp911de commented 3 months ago

Care to rebase your pull request, given the conflicting changes?

atakavci commented 3 months ago

hey @manish-manghwani ,

i got backgrounds of this while i was working on #2813 . do you mind if i take over this one ?

manish-manghwani commented 3 months ago

hey @manish-manghwani ,

i got backgrounds of this while i was working on #2813 . do you mind if i take over this one ?

hey @atakavci, sure please take over.

Do I need to close this PR?

atakavci commented 3 months ago

thanks, please do close this one. you can follow #2757 if you want to see the changes

redis / lettuce

Add support for SPUBLISH #2757 #2800