Closed atakavci closed 2 months ago
Attention: Patch coverage is 79.31034%
with 6 lines
in your changes are missing coverage. Please review.
Project coverage is 77.66%. Comparing base (
43843bf
) to head (5616087
). Report is 246 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Looks good. For the final merge, we typically squash all commits into one to keep one commit per ticket. That works well with tickets that introduce separate commands. @tishun do you want me to merge this one or do you want to merge it?
Please go ahead and thank you for the review!
That's squashed, merged, and polished now.
implementation for #2758
built on existing routing/command mechanism with adding 2 new interfaces (RedisShardedPubSubListener, RedisClusterShardedPubSubListener) to avoid breaking existing use cases. need to add some more tests, including SPUBLISH command to check listeners are working properly.