Closed gerzse closed 2 months ago
Attention: Patch coverage is 88.50575%
with 10 lines
in your changes are missing coverage. Please review.
Project coverage is 77.68%. Comparing base (
43843bf
) to head (d98c07a
). Report is 248 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Generally, the functionality is fine. There are some aspects that require further refinement:
- Our lettercasing uses camel-base based on word boundaries. Since
novalues
is a word on its own, method names should behscanNovalues
instead ofhscanNoValues
. We already have some mixture in letter casing. To align with how it should be, please use a lowercasev
as inNovalues
.- Missing
@since
tags. The next release aims towards 7.0, so please add@since 7.0
to all newly introducedpublic
methods. Adding the tag into the template is typically fine.- There are several unrelated changes such as changes to
RedisServerAsyncCommands
that result from committing all generated interfaces. Please remove these changes from the PR to have a focused pull request.
Thanks for the review!
hscan
method, so I'll try to cover those too, since hscanNovalues
is a general alternative to hscan
.Generally, the functionality is fine. There are some aspects that require further refinement:
- Our lettercasing uses camel-base based on word boundaries. Since
novalues
is a word on its own, method names should behscanNovalues
instead ofhscanNoValues
. We already have some mixture in letter casing. To align with how it should be, please use a lowercasev
as inNovalues
.- Missing
@since
tags. The next release aims towards 7.0, so please add@since 7.0
to all newly introducedpublic
methods. Adding the tag into the template is typically fine.- There are several unrelated changes such as changes to
RedisServerAsyncCommands
that result from committing all generated interfaces. Please remove these changes from the PR to have a focused pull request.Thanks for the review!
- I did notice in the codebase the drift in the naming rules. I will switch to the one that you suggested. Also I'll add tags.
- About the unrelated changes, you're right, they don't belong here. What happened is that I ran the code generator and got many differences, so I though doing something about that. I will open a separate PR only about aligning the templates with the current state of the code, if it's OK.
- Besides this, @atakavci pointed out that I missed some interfaces that have the
hscan
method, so I'll try to cover those too, sincehscanNovalues
is a general alternative tohscan
.
The code generator is a bit of Pandora's box, which I don't want to open. I ran the generator, reverted all the (quite many) unrelated changes, and kept strictly the changes related to HSCAN NOVALUES.
@atakavci @tishun feel free to merge.
Issue #2763
HSCAN has a new argument called NOVALUES. The effect is that only the keys in the hash are returned, without associated values.
Make sure that:
[ ] You submit test cases (unit or integration tests) that back your changes.