Closed tishun closed 2 months ago
Attention: Patch coverage is 90.47619%
with 2 lines
in your changes are missing coverage. Please review.
Project coverage is 77.73%. Comparing base (
43843bf
) to head (5dffa53
). Report is 249 commits behind head on main.:exclamation: Current head 5dffa53 differs from pull request most recent head 9e9483a. Consider uploading reports for the commit 9e9483a to get more accurate results
Files | Patch % | Lines |
---|---|---|
src/main/java/io/lettuce/core/RedisHandshake.java | 90.47% | 1 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Closes #2817
This solution aims to bring consistency between the Lettuce driver and most other drivers maintained by the Redis team. The current approach is - instead of probing for the version of the remote server and deciding based on that wether or not to send the CLIENT SETINFO command - to always send it and ignore the server response. There are two main reasons behind this: different flavors of the Redis server handle this in different versions and also the information sent is not critical to the operation of the driver, so failures should not necessary terminate the connection.
lib-name
andlib-ver
are set properly.Make sure that:
[x] You submit test cases (unit or integration tests) that back your changes.