redis / lettuce

Advanced Java Redis client for thread-safe sync, async, and reactive usage. Supports Cluster, Sentinel, Pipelining, and codecs.
https://lettuce.io
MIT License
5.3k stars 949 forks source link

Attempt to stabilize integration tests #2825

Closed tishun closed 2 months ago

tishun commented 2 months ago

Addressing several stability issues with the pipeline:

  1. Failing Integration tests would not fail the pipeline checks - this resulted in several tests constantly failing, and the number was rising. To address this I've added the failsafe plugin to the verify step, as suggested by the Maven best manual
  2. Removed the -B option in the Makefile to improve readability in the logs
  3. Modified the io.lettuce.core.SslIntegrationTests.pubSubSsl to attempt to verify the re-subscription process for a longer period of time, as it seems on the runners it takes more than 10 seconds (more than 60 seconds really)
  4. Modified the io.lettuce.core.cluster.pubsub.RedisClusterPubSubConnectionIntegrationTests.subscribeToShardChannelViaOtherEndpoint to instead test replica scenario, see discussion below
  5. Finished and enabled the testRegularClientPubSubShardChannels test

Make sure that:

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.74%. Comparing base (43843bf) to head (40c29d8). Report is 250 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2825 +/- ## ============================================ - Coverage 78.71% 77.74% -0.97% - Complexity 6786 7244 +458 ============================================ Files 508 539 +31 Lines 22765 24494 +1729 Branches 2446 2607 +161 ============================================ + Hits 17919 19044 +1125 - Misses 3717 4257 +540 - Partials 1129 1193 +64 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.