Open YorigamiShion opened 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 77.69%. Comparing base (
43843bf
) to head (004b471
). Report is 251 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Care to elaborate what kind of issue you're addressing before we jump right into the code?
I think flag
atomicBoolean
here is expected to make sure only one thread executessync.getConncetion().whenComplete
to remove the Sync from map when init is fail. However, the original implmentation will allow all threads executewhenComplete
if the connection is not initialized. Furthermore, callconnections.get
thenconnections.computeIfAbsent
is unnecessary.Make sure that:
[ ] You submit test cases (unit or integration tests) that back your changes.