Applying code formatter each time we run a Maven build

tishun commented 5 months ago

During the review of #2838 it was noticed that there are code formatting issues with the code that is already submitted in the repo. To avoid having these in the future I've added a step in the maven build to format the code.

As part of this the whole codebase was reformatted accordingly.

In the future, if the right formatter is used, there would be no formatting changes required in PRs.

Make sure that:

[x] You have read the contribution guidelines.
[x] You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
[x] You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
[x] You submit test cases (unit or integration tests) that back your changes.

mp911de commented 5 months ago

Would you mind backporting the pom changes to 6.2.x as well?

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 86.79245% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 77.71%. Comparing base (a91d701) to head (3709583).

:exclamation: Current head 3709583 differs from pull request most recent head 9c36afe. Consider uploading reports for the commit 9c36afe to get more accurate results

Files	Patch %	Lines
src/main/java/io/lettuce/core/RedisClient.java	64.28%	4 Missing and 1 partial :warning:
...main/java/io/lettuce/core/AbstractRedisClient.java	0.00%	2 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #2841 +/- ## ============================================ + Coverage 77.56% 77.71% +0.14% Complexity 7240 7240 ============================================ Files 539 539 Lines 24562 24492 -70 Branches 2609 2607 -2 ============================================ - Hits 19052 19033 -19 + Misses 4308 4264 -44 + Partials 1202 1195 -7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tishun commented 5 months ago

Would you mind backporting the pom changes to 6.2.x as well?

Not at all.

tishun commented 5 months ago

Oh, my bad ... why did I do that

tishun commented 5 months ago

Would you mind backporting the pom changes to 6.2.x as well?

Hey @mp911de , what about the 6.3.x ?

redis / lettuce

Applying code formatter each time we run a Maven build #2841

Codecov Report