DOC-4195: add TCEs to the range query page - Githubissues

redis / node-redis

Redis Node.js client

https://redis.js.org/

MIT License

16.95k stars 1.89k forks source link

DOC-4195: add TCEs to the range query page #2831

Closed dwdougherty closed 1 month ago

dwdougherty commented 2 months ago

Description

Tabbed code examples (TCEs) for the exact match query page. Please merge as soon as possible.

Checklist

[ ] Does npm test pass with this change (including linting)?
[ ] Is the new or changed code fully tested?
[ ] Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

sjpotter commented 1 month ago

@dwdougherty is it a problem that the test is failing?

dwdougherty commented 1 month ago

How is it failing? I runs successfully on my system.

sjpotter commented 1 month ago

github test "doctests" in the github actions ."all checks have failed"

dwdougherty commented 1 month ago

That's because the data file isn't in the branch (it was committed as part of another branch). When all the PRs are merged, it should be just fine.

sjpotter commented 1 month ago

so I comitted the first one, but still failing as query_em.json doesn't exist?

sjpotter commented 1 month ago

ok, merged in the initial pr into all of these PRs, helps me make progress.

sjpotter commented 1 month ago

@leibale looks fine to me, is there anything I'm not understanding that would be an issue?