redis / node-redis

Redis Node.js client
https://redis.js.org/
MIT License
16.85k stars 1.87k forks source link

Add support for Sentinel and RE Discovery Service #302

Open tanguylebarzic opened 11 years ago

tanguylebarzic commented 11 years ago

Hi,

Are there plans to make node_redis sentinel aware? I'm thinking about being able to use a list of sentinels at startup, then discover and connect to the masters, and subscribing to sentinels message to take into account masters changes. If not, would be happy to start working on it!

Tanguy

JustDoItSascha commented 7 months ago

Is it now implemented?

leibale commented 7 months ago

It's in the v5 branch waiting for some tests and last-minute changes, then we will release a "next"/beta version with it

jagdeepak-prat commented 6 months ago

Hope this comes soon to the main. :)

gianDiazM commented 3 months ago

Hi @leibale! I'd to know if there are any plans to release version V5 soon. I've noticed that the working branch is quite active, but I was wondering if there's a target date for releasing a stable or a beta version that includes the Sentinel package? :)

gianDiazM commented 2 months ago

Hi @leibale! I'd to know if there are any plans to release version V5 soon. I've noticed that the working branch is quite active, but I was wondering if there's a target date for releasing a stable or a beta version that includes the Sentinel package? :)

Hi again, my team have been closely following the development of the V5 version and is very interested in using the new features you are implementing. Additionally, our team is willing to work with you to speed up the development process so we can use the new version as soon as possible. If we can help, please let us know. We are open to performing tests, providing feedback, or contributing in any other way you find useful.

Thank you in advance

leibale commented 2 months ago

@gianDiazM first, sorry for the huge delay, I've complement missed your message from 2 weeks ago.. ATM we are working on:

  1. Client-side caching
  2. Finishing sentinel
  3. Aliging the commands

If you guys want to help with one of those, do performance tests, or just play around with the client, that would be very helpful. Do you need sentinel specifically to try it out? Can you try it directly from git or do you need an "npm version"?

gianDiazM commented 2 months ago

@gianDiazM first, sorry for the huge delay, I've complement missed your message from 2 weeks ago.. ATM we are working on:

  1. Client-side caching
  2. Finishing sentinel
  3. Aliging the commands

If you guys want to help with one of those, do performance tests, or just play around with the client, that would be very helpful. Do you need sentinel specifically to try it out? Can you try it directly from git or do you need an "npm version"?

Hi @leibale no worries and thank you for getting back to me. We will try to address the points you mentioned.

And regarding this "Can you try it directly from git or do you need an "npm version"?"

A Redis npm version that includes the client/sentinel package to integrate into our development would be great.

Thanks =)

Loki-Afro commented 1 month ago

@leibale we are in a very similar situation as @gianDiazM

what exactly means "finishing" sentinel?

and we kinda need a new tag