Move temporary dir deletion to inner function, delete temp dir in skipped benchmarks

redis / redis-benchmarks-specification

The Redis benchmarks specification describes the cross-language/tools requirements and expectations to foster performance and observability standards around redis related technologies. Members from both industry and academia, including organizations and individuals are encouraged to contribute.

Apache License 2.0

30 stars 11 forks source link

Move temporary dir deletion to inner function, delete temp dir in skipped benchmarks #245

Closed mpozniak95 closed 1 year ago

mpozniak95 commented 1 year ago

Probably connected with issue: https://github.com/redis/redis-benchmarks-specification/issues/244.

So far when some check resulted with skipping benchmark, it would keep an empty temporary directory in home directory. Deletion of temporary dir should happen in such situation before continuing to the next benchmark.

This PR moves temporary directory deletion to inner function in process_self_contained_coordinator_stream and invokes it before skipping any benchmark

mpozniak95 commented 1 year ago

I will open this PR from new branch located in this repository since looks like github jobs run for PR from forks doesn't have access to github secrets.