Bug when specifing "multiple" to a complex command

[yoav-steinberg]

This pr: https://github.com/redis/redis-doc/pull/1645 Caused the GET subcommand to replicate each time the BITFIELD_RO page was refreshed. See attached image.

[yoav-steinberg]

I think the issue happens when you have a complex subcommand which has more than one argument but can appear multiple time. Relevant commands are BITFIELD and BITFIELD_RO. If there are others please add them to this ticket. Once this is fixed we'll update commands.json accordingly.

[huangzhw]

I test in help.h, it is key GET type offset [GET type offset ...].

[yoav-steinberg]

I test in help.h, it is key GET type offset [GET type offset ...].

Yes, that's the correct usage of the command but for some reason when specifying "multiple":true in commands.json and we refresh the command's page a few times we get the above issue.

[itamarhaber]

After multiple refreshes, I could not reproduce :/

[yoav-steinberg]

Recreates for me (chromium and firefox). Apply following patch, run the site and go to: http://localhost:9292/commands/bitfield_ro

diff --git a/commands.json b/commands.json
index 4f40282..4fb49e0 100644
--- a/commands.json
+++ b/commands.json
@@ -278,7 +278,8 @@
         "type": [
           "type",
           "integer"
-        ]
+        ],
+       "multiple": true
       }
     ],
     "since": "6.2.0",

[itamarhaber]

Ok, I see it, confirmed :)