search

redis / redis-io

Application running http://redis.io
http://redis.io
637 stars 176 forks source link

Minor CSS Fixes #254

Open KartikSoneji opened 3 years ago

KartikSoneji commented 3 years ago

Minor CSS Fixes:

itamarhaber commented 3 years ago

Thank you @KartikSoneji!

This appears to do the job :)

image

Minor nitpicks:

Also, IIUC, the *zoom: 1 is the IE7 hack so that's good. I'm curious, however, as to how you verified that the h1 and h3 stuff is not needed?

KartikSoneji commented 3 years ago

It looks like the asterisk is lower than it should be (visually)

The original website had the asterisk even lower, I centred it vertically (by eye). I assumed the original designer used them as a stylized bullet (•Title), not as an asterisk (*Title).

image

Does it make sense to replace the asterisk with a link icon (e.g. fa-link?)

I think both are equally valid, it depends on the visual design. Although it would be better to use a pseudo element like ::before instead of an actual * in the markup, since pseudo elements cannot be selected or copied, and the asterisk is styling that should not be included in the content. This also has the benefit that if the style changes in the future, it only has to be updated in one place.

I'm curious, however, as to how you verified that the h1 and h3 stuff is not needed?

Oops. I just checked the output of grep -r "<h1" and grep -r "<h3" without noticing the templates were not HTML. The styles will need to be updated, the current version (on redis.io) is broken for h3.

image

Would you prefer I revert the commit or rebase and force-push?

itamarhaber commented 3 years ago

I think both are equally valid

I trust your eye - please feel free to change/re-style/keep as is.

... or force push

Force push is fine :)

KartikSoneji commented 3 years ago

Is there any particular reason for cramming each rule into a single line? More importantly, is there a good reason to preserve the formatting?

Also, both views/grid.scss and views/normalize.scss don't seem to be used, nor does the project download or use the sass compiler. Is there any point in keeping the files in the repo?