search

redis / redis-om-node

Object mapping, and more, for Redis and Node.js. Written in TypeScript.
MIT License
1.18k stars 80 forks source link

Old code using string for Schema definitions doesn't work #167

Closed spdrman closed 1 year ago

spdrman commented 1 year ago

This was from using the library in a Typescript app. I kept getting an error because 'album' couldn't be used in place of ctor: EntityConstructor

guyroyse commented 1 year ago

The README in main branch is for Redis OM 0.4.0 beta as noted at the top of the README and thus the code examples are also for that version. For the current non-beta version, see the README at NPM.

guyroyse commented 1 year ago

Would really like it if you'd try out the beta though!

spdrman commented 1 year ago

Hahaha I got confused by the "Beta" next to code in npm... unfortunately it looks like npm is trying out a Beta feature of their own, and it is unfortunately attached to Code, which made me believe that the npm contained the Beta version of the redis-om code hahaha:

image

May I suggest putting the Beta Documentation notice at the TOP of the README, instead of after the branding? I totally missed that message, or didn't clue into it.

guyroyse commented 1 year ago

It ain't just you. It actually confused me a couple of times when I saw it as well. Kept trying to click on it to get to the Beta version of Redis OM!

spdrman commented 1 year ago

It ain't just you. It actually confused me a couple of times when I saw it as well. Kept trying to click on it to get to the Beta version of Redis OM!

I switched to beta. Definitely an improvement.

Will report issues.

Thanks for manning this post. Appreciate ya!