Set membership (IN, contains) not working for numeric types

redis / redis-om-python

Object mapping, and more, for Redis and Python

MIT License

1.12k stars 112 forks source link

Open doc-hex opened 1 year ago

doc-hex commented 1 year ago

in FindQuery.resolve_value() the case for Operators.IN and Operators.NOT_IN is not considered.

result is syntax error
recommend having an else: raise ValueError on this sort of case statement code

doc-hex commented 1 year ago

Related concern: how do I search for a range of numeric values?

doing field >= 200 and field < 213 works, but is done as:

NUMERIC {200.000000 <= @kind <= inf} NUMERIC {-inf <= @kind <= 213.000000}
when I can do it manually and get it explained as:

NUMERIC {200.000000 <= @kind <= 213.000000}

Maybe there is no difference in execute time.