search

redis / redis-om-python

Object mapping, and more, for Redis and Python
MIT License
1.09k stars 108 forks source link

fix: proper python 3.11 support #446

Closed YaraslauZhylko closed 1 year ago

YaraslauZhylko commented 1 year ago

Description

Properly support Python 3.11 versions.

Related issues

codecov-commenter commented 1 year ago

Codecov Report

Base: 78.87% // Head: 78.85% // Decreases project coverage by -0.01% :warning:

Coverage data is based on head (946d9c5) compared to base (1e33e25). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #446 +/- ## ========================================== - Coverage 78.87% 78.85% -0.02% ========================================== Files 14 14 Lines 1174 1173 -1 ========================================== - Hits 926 925 -1 Misses 248 248 ``` | Flag | Coverage Δ | | |---|---|---| | unit | `78.85% <ø> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=redis#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/redis/redis-om-python/pull/446?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=redis) | Coverage Δ | | |---|---|---| | [aredis\_om/model/model.py](https://codecov.io/gh/redis/redis-om-python/pull/446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=redis#diff-YXJlZGlzX29tL21vZGVsL21vZGVsLnB5) | `87.02% <0.00%> (-0.02%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=redis). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=redis)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

YaraslauZhylko commented 1 year ago

Am I supposed to fix the dependency vulnerability as well? https://github.com/redis/redis-om-python/actions/runs/3770460277/jobs/6418717485#step:5:111

Or should it be done in a separate PR?

YaraslauZhylko commented 1 year ago

I guess, the vulnerability is not fixable at the moment as gitpython==3.1.29 is the latest available version of the package and no fix has been released yet.

So "admin merge" of this PR may be an option to move forward.

YaraslauZhylko commented 1 year ago

With the vulnerability ignored, all jobs now pass successfully.

Still need a re-approval, as the previous ones got automatically (?) dismissed.