Closed marianhlavac closed 1 year ago
Patch coverage: 100.00
% and project coverage change: +0.01
:tada:
Comparison is base (
70f6401
) 78.94% compared to head (a8710a5
) 78.96%.
:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
I've rebased the PR on latest main
from upstream. The checks should pass now.
Is anything else blocking this PR?
I think this is a necessary change, is there a reason it was not merged?
Well very obviously this project is beyond being unmaintained, which is really shame.
Classes RedisModel, HashModel and JsonModel had wrong return type definitions on some of their methods.
This effectively prevented static type checking and typehinting on all objects returned by these methods.
This PR adds correct type hints using TypeVars.
This superseeds PR https://github.com/redis/redis-om-python/pull/472