Closed arareko closed 2 months ago
@slorello89 Can you have a look at this? Thanks!
Looking forward for this pull request to be merged ! š Thanks @arareko ! Would be really nice from you @slorello89 if you can merge it if you think everything is good from your side ! š
@slorello89 Any chance you can have a look at this?
LGTM š thanks for submitting @arareko
Can we get a new version on pypi with these changes? @slorello89
This updates
RedisModel
to usemodel_config
with the right parameters (e.g.from_attributes
) instead of theConfig
class with deprecated attributes (e.g.orm_mode
) when Pydantic 2.x is installed. It will most likely resolve the warning shown in #612, but not the main issue reported there.I found the above warning while running a FastAPI app in uvicorn within a Python 3.12 virtualenv and the following packages:
This also fixes a few warnings/issues I encountered while testing my changes with
make format/lint/test
.