fix: cast from db connections with non decoded output

redis / redis-om-python

Object mapping, and more, for Redis and Python

MIT License

1.13k stars 114 forks source link

fix: cast from db connections with non decoded output #664

Open ivanbelenky opened 2 weeks ago

ivanbelenky commented 2 weeks ago

Describe your changes

As stated on this issue, the connections objects may be set without decoding. Therefore, the stored hash can be a bytes object. This is an issue that clashes with

schema_out_of_date false positive: different type will force inequality checks to always be True
IndexMigration expects previous_hash to be of str type

This small check and reassignment for stored_hash, fixes the issue and enables correct detection.

ivanbelenky commented 2 weeks ago

@sav-norem @bsbodden (saw slorello in PR #663 tagging you, so Ill repeat the pattern)

I am all ears for suggestions &| clarifications on this one