Improve parsing of XINFO STREAM response

Wh1isper commented 2 weeks ago

Please make sure to review and check all of these items:

[x] Do tests and lints pass with this change?
[x] Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
[x] Is the new or changed code fully tested?
[ ] Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
[ ] Is there an example added to the examples folder (if applicable)?
[ ] Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Please provide a description of the change here.

closes: #3065

And also fix when there is no group(data["groups"] == []) and parse consumer by defualt

Wh1isper commented 2 weeks ago

This is a tiny fix, I can add test cases and changelogs for this if needed

gerzse commented 2 weeks ago

This is a tiny fix, I can add test cases and changelogs for this if needed

Thanks @Wh1isper

It would be great if you can add tests, one with a response before XTRIM, one for a response after XTRIM.

Wh1isper commented 2 weeks ago

@gerzse I've added test code for this change on the original xinfo_stream and xinfo_stream_full test cases, please take a look

gerzse commented 2 weeks ago

Thanks for the tests @Wh1isper

redis / redis-py