redis / redis-py

Redis Python client
MIT License
12.68k stars 2.53k forks source link

Avoid stacktrace on process exit in Client.__del__() #3397

Open noirbee opened 1 month ago

noirbee commented 1 month ago

Pull Request check-list

Please make sure to review and check all of these items:

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Client.close() may call ConnectionPool.release() or ConnectionPool.disconnect(); both methods may end up calling os.getpid() (through ConnectionPool._checkpid() or threading.Lock() (through ConnectionPool.reset()). As mentioned in the Python documentation [1], at interpreter shutdown, module globals (in this case, the os and threading module references) may be deleted or set to None before del() methods are called. This causes an AttributeError to be raised when trying to run e.g. os.getpid(); while the error is ignored by the interpreter, the traceback is still printed out to stderr.

Closes #3014

[1] https://docs.python.org/3/reference/datamodel.html#object.__del__

noirbee commented 1 month ago

Note that I unfortunately cannot provide an easy way to reproduce the issue; I can only reproduce it using our own codebase. I suspect this is due to the fact that we load a much larger amount of code than what a synthetic / minimal reproduction attempt would.