search

redis / redis-rb

A Ruby client library for Redis
MIT License
3.97k stars 1.03k forks source link

Support role being specified as a string #1217

Closed dhruvCW closed 1 year ago

dhruvCW commented 1 year ago

sometimes the redis options are provided as a hash with string values.

This is true in my case where the configurations are read as a json object from an environment variable.

Given that only the role is expected to be a symbol, It is a much better user experience if the conversion was handled internally by the library instead of requiring the user to handle it themselves.

byroot commented 1 year ago

I could be open to this, but this would need to be done in redis-client, not here.

dhruvCW commented 1 year ago

I could be open to this, but this would need to be done in redis-client, not here.

awesome, wasn't really sure if that was something you might be open to or not. Will open a PR there 👍