search

redis / redis-rb

A Ruby client library for Redis
MIT License
3.97k stars 1.03k forks source link

Multi/exec blocks are not retried on error #1285

Closed jdheyburn closed 3 months ago

jdheyburn commented 3 months ago

I'm seeing that our multi/exec calls defined as below are not retried in the event of an error, despite reconnect_attempts > 0. This isn't the case for our other commands.

redis.multi do |multi|
  multi.set("foo", "bar")
end

I wanted to add a test for this but I am not well-versed in Ruby. Is this by design or a bug?

byroot commented 3 months ago

Is this by design or a bug?

It's not by design, but I also have no indication this bug exists, because the code is very explicit about retrying them.

So unless you got some test or reproduction, this issue won't be actionable for me.

byroot commented 3 months ago

Closing until a reproduction is provided.