Align rueidiscompat with go-redis

redis / rueidis

A fast Golang Redis client that supports Client Side Caching, Auto Pipelining, Generics OM, RedisJSON, RedisBloom, RediSearch, etc.

Apache License 2.0

2.42k stars 152 forks source link

Align rueidiscompat with go-redis #380

Closed rueian closed 10 months ago

rueian commented 1 year ago

Although the command builder of rueidis already supports all commands of redis, including commands of RediTimeseries, RedisJSON, RedisBloom, and RediSearch, the rueidiscompat doesn't support those modules.

go-redis recently added support for them via the following interfaces:

[x] GearsCmdable
[x] ProbabilisticCmdable
[x] TimeseriesCmdable

We should also implement them in the rueidiscompat.

unknowntpo commented 1 year ago

I can help, give me some time to get familiar with the code base.

unknowntpo commented 1 year ago

Survey:

we need to implement this interface.

GearsCmdable https://github.com/redis/go-redis/blob/f994ff1cd96299a5c8029ae3403af7b17ef06e8a/gears_commands.go#L9-L19
ProbabilisticCmdable https://github.com/redis/go-redis/blob/f994ff1cd96299a5c8029ae3403af7b17ef06e8a/probabilistic.go#L10
TimeseriesCmdable https://github.com/redis/go-redis/blob/f994ff1cd96299a5c8029ae3403af7b17ef06e8a/timeseries_commands.go#L10-L40

And I plan to use interface embedding to put these method to embed methods to Cmdable interface, because the number of methods inside Cmdable is a bit too large.

rueian commented 10 months ago

All these Cmdable interfaces have already been added by unknowntpo. Thank you for your great work! @unknowntpo