Becomes a standalone extension that works with deno extensions

redking00 / vscode-nbts

DenoNBTS is a fork of the original VSCode Deno extension from denoland and adds support for deno lsp on notebooks. It also defines a new type of notebook (*.nb.ts) and provides a kernel to run them without Python.

https://marketplace.visualstudio.com/items?itemName=redking00.vscode-nbts

MIT License

9 stars 0 forks source link

Becomes a standalone extension that works with deno extensions #5

Open janckerchen opened 1 week ago

janckerchen commented 1 week ago

Standalone extensions are probably better than the fork approach.

I've looked at the changes, and the main ones are the addition of Session, Deno spawn, serializer, which could have been standalone extensions to work with vscode-deno. I don't really understand why they are integrated.

vscode-deno already provides lsp, so I don't understand why it needs additional support.

redking00 commented 1 week ago

Take a look on this issue for some background on the lsp problem.

Currently the extension is a fork due to the lsp issue. I would love to see the official lsp updated in its own repo (deno) and the controller and serializer in the official extension repository, but if that were not the case, I would publish the controller and serializer as add-on extensions.

redking00 commented 5 days ago

@janckerchen, Added support for running typescript ipynb files on the controller.

janckerchen commented 5 days ago

Wow, I can get rid of all the Jupyter plugins and Python environments, and I feel completely refreshed.