redkyn / assigner

:black_nib: Automatically assign programming homework to students on GitLab.
MIT License
27 stars 6 forks source link

Added Travis CI Configuration #94

Closed brhoades closed 6 years ago

brhoades commented 6 years ago

WIP: Not sure if this is done, I need Travis to pick up this branch first. Cool, pyflakes works. I'll add flake8 and do linting for an hour.

Fixes #81 and fixes #80

brhoades commented 6 years ago

@LinuxMercedes I'd appreciate it if you could run this branch through a few tests on gitlabs. I can only confirm so much.

LinuxMercedes commented 6 years ago

Holy crap this is nice! I'll run it through its paces tomorrow morning.

LinuxMercedes commented 6 years ago

I've poked this some and it seems to work just fine! I'll probably run it through its paces on 5201 homework 1 before I'm comfortable merging it, though.

@brhoades does this fix any bugs or is it "just" syntax changes? If it's the latter, I will probably just roll this into the next release, whenever that happens.

brhoades commented 6 years ago

There was some bug that pylint claimed to find where BaseRepo.name = "" was overriding StudentRepo.name(), but since the latter is a classmethod this was a nonissue.

LinuxMercedes commented 6 years ago

@brhoades Can you clean the commit history up some and then let's merge this!

brhoades commented 6 years ago

I'll just squash on merge.