redleafnew / delitemwithatt

Remove attachment(s) when delete the item(s) or collection in Zotero and JurisM.
GNU Affero General Public License v3.0
554 stars 11 forks source link

Files remain on the harddrive #13

Closed adeldaoud closed 2 years ago

adeldaoud commented 2 years ago

Hi! I tried delitemwithatt, and it removes the attachment in Zotero but the files remain on the harddrive. That defeats the purpose of this plugin. Is this a bug perhaps?

redleafnew commented 2 years ago

image Do you use the context menu in this plugin?

adeldaoud commented 2 years ago

Yes, I deleted the html folder attachment from there, but the folder remains. Is there a difference between file and a folder attachment perhaps?

Sent from Outlook for iOShttps://aka.ms/o0ukef


From: redleafnew @.> Sent: Tuesday, November 15, 2022 7:11:46 AM To: redleafnew/delitemwithatt @.> Cc: Daoud, Adel @.>; Author @.> Subject: Re: [redleafnew/delitemwithatt] Files remain on the harddrive (Issue #13)

[image]https://urldefense.proofpoint.com/v2/url?u=https-3A__user-2Dimages.githubusercontent.com_22135631_201839638-2D0ca5b4e5-2D7935-2D4a6a-2Da7f0-2Dcad31b45630e.png&d=DwMCaQ&c=WO-RGvefibhHBZq3fL85hQ&r=KRo3KG3YOnfxs9qHkn7qxk0n36iegcWkciCSfniicA4&m=RcSr83rOuvw-1qppguU2GQNXRnAHIVqyjCgYrnU66BLGIoyyUEe_iUbsOjai1o0T&s=7ZZ2dCkphAW5kAN4fhVvtf_kssagxqexI6OxA3SKsZQ&e= Do you use the context menu in this plugin?

— Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_redleafnew_delitemwithatt_issues_13-23issuecomment-2D1314823600&d=DwMCaQ&c=WO-RGvefibhHBZq3fL85hQ&r=KRo3KG3YOnfxs9qHkn7qxk0n36iegcWkciCSfniicA4&m=RcSr83rOuvw-1qppguU2GQNXRnAHIVqyjCgYrnU66BLGIoyyUEe_iUbsOjai1o0T&s=VHI89qsTBXqteJroAzTk86S6s8Hn4fL2KFBjUGHEYVc&e=, or unsubscribehttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ACH6SQRKV76K6XZX4UM6KG3WIMSSFANCNFSM6AAAAAASAR6MHA&d=DwMCaQ&c=WO-RGvefibhHBZq3fL85hQ&r=KRo3KG3YOnfxs9qHkn7qxk0n36iegcWkciCSfniicA4&m=RcSr83rOuvw-1qppguU2GQNXRnAHIVqyjCgYrnU66BLGIoyyUEe_iUbsOjai1o0T&s=5scNFqu0MY5jzc2Z1ttKUg6D82WTrncOz1y4MGf1SDM&e=. You are receiving this because you authored the thread.Message ID: @.***>

redleafnew commented 2 years ago

The folder deletion has been considered, and did not added in the plugin in case of there were more than one files in the folder.

redleafnew commented 2 years ago

And you can scan and delete the empty folder with other application if there is only one file in the folder.

adeldaoud commented 2 years ago

I see. It would be very useful to delete folders as well, as HTML items will be saved in a folder with multiple files. Those multiple fiels are the ones that are hardest to get rid off manually. Would it be possible to add that feature of deleting a folder? It would be very very useful.

redleafnew commented 2 years ago

It will not happen in the near future, sorry. For the HTML items, they could be saved as single web page file with mhtml as the extenstion. image

adeldaoud commented 2 years ago

Good idea reagrding the mhtml. Sorry to hear that it will not be supported any time soon. Incidentally, do you have a suggestion for how I can get rid of those specific folders from Zotero and my harddrive in a batch operation?

Zotero creates those folders for HTML attachments from the past, containing multiple files. I really would like to batch delete all items with HTML folders. I am setting up a sync folder solution on Onedrirve, according to Zotero instructions of splitting the database and attached files. However, having a myriad of tiny files is creating issues for OneDrive

redleafnew commented 2 years ago

After searching, the script was found, however, I did not try it.

https://devblogs.microsoft.com/oldnewthing/20080417-00/?p=22703

adeldaoud commented 2 years ago

Thanks for the tip. However, the Zotero storage folders I am referring to are not empty. They live in the Zotero storage folder like so, and wondering if those can be deleted, for the ones with HMTL files. image

redleafnew commented 2 years ago

You could use ZotFile, move the attachments to another folder, then the attachnents with items will be moved the folder, and the orphan attachments will not.

dstillman commented 2 years ago

@redleafnew: This is just a misunderstanding on @adeldaoud's part:

https://forums.zotero.org/discussion/comment/422179/#Comment_422179