💡 Feature request: Make the UI Palette Swap Optional

redlib-org / redlib

Private front-end for Reddit

GNU Affero General Public License v3.0

1.26k stars 88 forks source link

💡 Feature request: Make the UI Palette Swap Optional #282

Closed np22-jpg closed 1 week ago

np22-jpg commented 2 weeks ago

Describe the feature you would like to be implemented

In older versions of redlib, most of the UI was white/aqua. The aqua parts are now a neon red, which users such as myself may find disorienting. This was merged in #280. It would be nice if the palette change was a setting instead, such that the old aqua UI is accessible again.

Additional context / screenshot

Current: Old:

sigaloid commented 2 weeks ago

Good point, this should be duplicated into an old theme file.

DokterKaj commented 2 weeks ago

Could the old theme be named "Libreddit"? Or should uses of "Reddit" be avoided everywhere?

DokterKaj commented 2 weeks ago

Also on the topic of the neon red being disorienting, what do you think of #c2002c for dark and #a30026 for light/black?

DokterKaj commented 2 weeks ago

Dark:

Light:

Logo: logo

rdadm0 commented 2 weeks ago

i guess we doing red ui now

ButteredCats commented 2 weeks ago

Imo the new red is far too strong on things like the sorting buttons. Also, a new favicon.ico needs to be made so the new logo appears on the tab for the site.

epic0421 commented 2 weeks ago

What if the accent color was configurable?

Lanklow commented 2 weeks ago

Dark:

Light:

Logo:

I like the idea of setting these as the default options, then adding light/dark mode accent configuration.

Trit34 commented 2 weeks ago

@Lanklow Your pics don’t show.

DokterKaj commented 2 weeks ago

@Trit34 it was a reply to my comment above: https://github.com/redlib-org/redlib/issues/282#issuecomment-2396726175

DokterKaj commented 2 weeks ago

@ButteredCats I've got a PR for that (#281) but I think I'll put it on hold until a better default red is decided on.

ntkoopman commented 2 weeks ago

The red on black (and black on red) is completely unreadable to me, I had to change the theme. It passes WCAG 2 AA standards, but fails on AAA and APCA: https://www.myndex.com/APCA/?BG=161616&TXT=ff0000&DEV=G4g&BUF=A22 (the results is "SPOT & NON TEXT ONLY" with a minimum 84px font size.

DokterKaj commented 2 weeks ago

The red on black (and black on red) is completely unreadable to me, I had to change the theme. It passes WCAG 2 AA standards, but fails on AAA and APCA: https://www.myndex.com/APCA/?BG=161616&TXT=ff0000&DEV=G4g&BUF=A22 (the results is "SPOT & NON TEXT ONLY" with a minimum 84px font size.

Hm, looks like red and black simply innately don't contrast well How does #ff6666 look?

Dark:

Logo: logo

extremelyonline commented 2 weeks ago

It may be useful to use color combinations that is muted and work together well. Using tools like Coolors (#a71d31 fits with the current dark colors) or an existing scheme like Flexoki.

DokterKaj commented 2 weeks ago

It's hard to tell what red would work best, since a colour that looks fine on a monitor can look too muted on a phone, while a colour that looks bright on a phone can be blinding on a monitor I also noticed that #ff6666 is quite similar to the NSFW tag colour (#ff5c5d), so I looked back at darker reds again Personally I think #cc3344 is a fair compromise, although it should be noted that any darker red fails abysmally at all the contrast tests

Dark:

Logo: logo