search

redlor / Minitask

Simple and lightweight todo list/task list for Android
Apache License 2.0
12 stars 8 forks source link

Added Delete confirmation Dialog in the details Activity #10

Closed Bradzer closed 6 years ago

redlor commented 6 years ago

@Bradzer thank you for the pull request! I was looking at the code, not merged yet. I think the dialog won't survive a screen rotation, did you try it? Let me know. Many thanks and best wishes!

Lorenzo

Bradzer commented 6 years ago

@redlor

Indeed I made the test and the dialog didn't survive the screen rotation. I started solving the issue. I made progress but still having a problem with firebase.

Maybe you can have a look on the code. Is it okay for you ?

redlor commented 6 years ago

@Bradzer happy new year! Yes, I'll copy your code and make some tests as soon as I can. In the meantime, try yourself doing researches and making tests, this will help you learning new things. The app made a lot of progresses but there are still many things to do. Many thanks for helping.

redlor commented 6 years ago

@Bradzer I did some changes to the code: I removed the part to cancel the item in SQL since there is no SQL database anymore. I also added a method to keep the dialog on orientation change. In addition, there was a problem crashing the app when clicking the confirmation button: the updateFirebase class was not instantiated so I added the code to do it:

updateFirebase = new UpdateFirebase();

I didn't test on a tablet yet but should work. I'll push later. Thank you and keep up the good work!