search

redlor / Minitask

Simple and lightweight todo list/task list for Android
Apache License 2.0
12 stars 8 forks source link

Delete confirmation dialog also in the details activity #5

Closed redlor closed 6 years ago

redlor commented 6 years ago

it would be good to have a confirmation dialog when the delete button in the details activity is clicked.

Bradzer commented 6 years ago

Working on this. Hope I'll be useful. It's my first time ;)

redlor commented 6 years ago

Hi @Bradzer

thank you for helping. I opened this issues to get help and also to give the chance to get experience to people new to Android, so your help is very welcome. About the task, feel free to have a look to my code in the MainActivity, I implemented a confirmation dialog there already. You can start with it, but if you want to go with DialogFragment instead, feel free to. I learned many things by starting doing something I didn't know how to do in the beginning. Let me know if you need help and many thanks!!!

Bradzer commented 6 years ago

Hi @redlor

I'm still a beginner (started few months ago) in Android development and I feel so lucky to collaborate with such friendly people like you.

Thanks a lot to give me the chance to get some experience by working with you.

I won't hesitate to let you know when I need help ;)

redlor commented 6 years ago

I found that if I rotate when the dialog is showing it crashes the app

redlor commented 6 years ago

should have been fixed #25