search

redmica / redmine_ip_filter

3 stars 3 forks source link

Fix that error_filter_rules_include_others does not show an actual network address #21

Closed vividtone closed 4 years ago

vividtone commented 4 years ago

Suppose that you attempt to save the following values to Allowed IP addresses:

198.51.100.10
198.51.100.0/24

Since 198.51.100.10 is included in the block 198.51.100.0/24, you will see an error message "Allowed IP addresses cannot be saved because 198.51.100.10 is in the range of 198.51.100.0.". However, 198.51.100.0 is different from 198.51.100.0/24, the value you entered.

This pull request fixes the error message to display the exact value you entered, like ""Allowed IP addresses cannot be saved because 198.51.100.10 is in the range of 198.51.100.0/24."

image

takenory commented 4 years ago

Thanks for reporting the problem & suggesting improvements!