search

redmine-git-hosting / redmine_git_hosting

A Redmine plugin which makes configuring your own Git hosting easy ;)
http://redmine-git-hosting.io
MIT License
274 stars 117 forks source link

very low factory_bot_rails max gem version - development mode #821

Open prahal opened 1 year ago

prahal commented 1 year ago

The Gemfile has in its development section:

-  gem 'factory_bot_rails', '< 5.0'

Debian stable bullseye is at minimum 5.1.1-2 for ruby-factory-bot-rails? Could the minimum get increased?

The current maximum in Debian unstable is 6.2.0-1 so I set it to < 7. But I have no idea what this requirement is about, thus which value is safe.

The issue is also on the Debian side as Debian redmine postinst runs bundle --local --quiet without "development" and "test" skipped. Thus the Redmine postinst script requires the above development gems on each gem upgrade. I believe this Debian behavior can be fixed. Still the dependency is really old. This might be aleftover.

prahal commented 1 year ago

Debian is not the issue. I reminded and verified that bundler requires all gems to be available at resolve time be they development, test, or production. The BUNDLE_WITHOUT is only for the installation step.

As Debian redmine runs bundle with --local it thus requires all gems to be installed before that step.

Having a 'factory_bot_rails' minimum version that supports Debian packaged version of this gem would be great. Else one will have to package an old version of ruby-factory-bot-rails for current Debian releases.