Refactor Config and Variables

redmod-team / profit

Probabilistic Response mOdel Fitting with Interactive Tools

https://profit.readthedocs.io

MIT License

14 stars 9 forks source link

Refactor Config and Variables #142

Closed mkendler closed 3 years ago

mkendler commented 3 years ago

[x] Add more sophisticated Encoder class structure.
[x] Add Variable classes.
[x] Add global defaults.py file to store all default config values.
[x] Add hierarchical Config class structure. Close #110
[x] Add docstrings.
[x] Move handle_config methods to the Config subclasses. Close #132

mkendler commented 3 years ago

@Rykath (maybe also @krystophny) please also check the zeromq interface and slurm runner.

Rykath commented 3 years ago

The zeromq error appeared already in the Fix tests commit but not in v0.4. GitHub says, the test passed, but displays the two warnings (the error miraculously does not appear for python 3.7) as Annotations in the test overview and with dedicated messages when reviewing the code which triggered the errors.

Rykath commented 3 years ago

@Rykath (maybe also @krystophny) please also check the zeromq interface and slurm runner.

I just checked the mockup example on acluster, works well!