Async to sync - Githubissues

rednafi / fastapi-nano

🐍 Simple FastAPI template that mimics Flask's blueprint directory structure

MIT License

893 stars 95 forks source link

Async to sync #272

Closed kareemmahlees closed 1 year ago

kareemmahlees commented 1 year ago

Changes

changes async functions to sync
fixed some typing issues

The tests needed no change and they all still run fine. The change was not massive but I am looking forward to contributing more in the future 🙂

closes #271

kareemmahlees commented 1 year ago

@rednafi Any comments? if all is fine there is still one pending workflow that needs to be run or approved idk :)

rednafi commented 1 year ago

@rednafi Any comments? if all is fine there is still one pending workflow that needs to be run or approved idk :)

@kareemmahlees Check the review comment please. It looks good, other than one minor issue.

rednafi commented 1 year ago

@rednafi Any comments? if all is fine there is still one pending workflow that needs to be run or approved idk :)

@kareemmahlees Check the review comment please. It looks good, other than one minor issue.

Merged with the fix, thank you!