Closed kareemmahlees closed 1 year ago
@rednafi Any comments? if all is fine there is still one pending workflow that needs to be run or approved idk :)
@rednafi Any comments? if all is fine there is still one pending workflow that needs to be run or approved idk :)
@kareemmahlees Check the review comment please. It looks good, other than one minor issue.
@rednafi Any comments? if all is fine there is still one pending workflow that needs to be run or approved idk :)
@kareemmahlees Check the review comment please. It looks good, other than one minor issue.
Merged with the fix, thank you!
Changes
The tests needed no change and they all still run fine. The change was not massive but I am looking forward to contributing more in the future 🙂
closes #271