search

rednir / OsuSkinMixer

Create a skin mix in a couple clicks.
MIT License
124 stars 3 forks source link

When using the Instafade option on a skin that doesnt include 2x elements skin mixer places generic elements in the skin #134

Closed AkiraTenchi closed 2 months ago

AkiraTenchi commented 2 months ago

Hey when using the Instafade option on a skin that doesn't include 2x elements skin mixer places generic elements in the skin. I think a check if 2x elements before applying changes and not randomly including generic 2x elements would be great since rn you need to go into every skin and delete the generic elements manually for the skin to be usable. If more detail is required let me know i can make a video showcasing the issue.

AkiraTenchi commented 2 months ago

This is what it looks like rn after instafading Screenshot 2024-08-17 at 17 03 39 and this is what it is supposed to look like Screenshot 2024-08-17 at 17 04 11

AkiraTenchi commented 2 months ago

I assume this could be fixed by just returning here https://github.com/rednir/OsuSkinMixer/blob/bb3ec26d20e29633185edfccc475408ae2ff4eef/src/Utils/SkinModifierMachine.cs#L249 and here https://github.com/rednir/OsuSkinMixer/blob/bb3ec26d20e29633185edfccc475408ae2ff4eef/src/Utils/SkinModifierMachine.cs#L253 instead of loading default elements I am however not certain if this is the best solution. I am not a C# dev so this is all a bit of conjecture on my end.

rednir commented 2 months ago

Fixed in the latest release, launch osu! skin mixer to update