v2.5

[redouane59]

• Fixing some log messages : https://github.com/redouane59/twittered/pull/241/
• Fixing User and Twitter object serialization : https://github.com/redouane59/twittered/pull/244
• Fixing searchAllTweets method https://github.com/redouane59/twittered/pull/255
• Global code reformatting
• Setting v1 search method as Deprecated and removing the old getFavorites() method

[calves07]

ETA on this release?

[redouane59]

ETA on this release?

I will try to release it next week-end as a maximum, stay tuned :)

[calves07]

ETA on this release?

I will try to release it next week-end as a maximum, stay tuned :)

Anyway I can easily use this version before the official release?

[redouane59]

Anyway I can easily use this version before the official release?

Yes I guess that you can just fork and build it locally

[calves07]

I forked the project as suggested but I wasn't able to serialize the objects. I had to add implements Serializable in classes UserV2, UserData and UserPublicMetrics. Now yes, I can serialize objects.

[redouane59]

I had to add implements Serializable in classes UserV2, UserData and UserPublicMetrics. Now yes, I can serialize objects.

That's not normal. Can you just launch the unit test testSerialization() in UserDeserializerV2Test.java and tell me if it passes ? Because on my side it is.

[sonarcloud[bot]]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
174 Code Smells

46.0% Coverage
0.0% Duplication

[calves07]

The test did pass, yes, but in my own project it still failed to serialize with

FileOutputStream fileOut = new FileOutputStream(file);
ObjectOutputStream out = new ObjectOutputStream(fileOut);
out.writeObject(object);
out.close();
fileOut.close();

After implementing Serializable, there are no longer exceptions and it works fine.

[redouane59]

After implementing Serializable, there are no longer exceptions and it works fine.

Are you sure your project is using this new version ?

I just created the same test in class TweetDeserializerV2Test and it is working, with a UserData object inside the main object.

[calves07]

Yes.

De: Redouane @.> Enviado: 5 de julho de 2021 14:19 Para: @.> Cc: @.>; @.> Assunto: Re: [redouane59/twittered] v2.5 (#242)

After implementing Serializable, there are no longer exceptions and it works fine.

Are you sure your project is using this new version ?

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/redouane59/twittered/pull/242#issuecomment-874107831, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AD34HLRQZICJ32WAK3ALQZLTWGWMLANCNFSM47YF64YA.

[redouane59]

Can you please write to me here your full test please ?

[calves07]

Just get a random UserV2 or User or UserData object.

Then call this function:

public static boolean serialize(Object object, String file) {
        try {
            FileOutputStream fileOut = new FileOutputStream(new File(file));
            ObjectOutputStream out = new ObjectOutputStream(fileOut);
            out.writeObject(object);
            out.close();
            fileOut.close();
        } catch (Exception ex) {
            return false;
        }
        return true;
    }

In my tests with a similar function, NotSerializableException was thrown.

[redouane59]

Thank you very much, I'm currently debugging that :)

[redouane59]

I just merge the PR https://github.com/redouane59/twittered/pull/249 . Could you just try this :

  @Test
  public void getAndSerializeUser() throws IOException {
    String userName = "RedouaneBali";
    User   result   = twitterClient.getUserFromUserName(userName);
    assertNotNull(TwitterClient.OBJECT_MAPPER.writeValueAsString(result));
    TwitterClient.OBJECT_MAPPER.writeValue(new File("../test_serialization.json"), result);
  }

On my side, after having added some @JsonIgnore annotations on methods which gave NPE on DTO classes, it's now working :)

[sonarcloud[bot]]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
186 Code Smells

43.3% Coverage
0.0% Duplication