redouane59 / twittered

Twitter API client for Java developers

Apache License 2.0

237 stars 65 forks source link

Closed rzo1 closed 3 years ago

rzo1 commented 3 years ago

What does this PR do?

Adds support for basic entities (hashtags, cashtags, mentions, urls) in V1 and V2 tweet objects.

rzo1 commented 3 years ago

Sorry - had to push an additional fix.

Looks like https://developer.twitter.com/en/docs/twitter-api/data-dictionary/object-model/tweet is wrong as it states tag for mentions instead of username but returns username in fact...

redouane59 commented 3 years ago

Finally they are a lot of not needed Jackson annotation, if you can just remove them and I'll merge the PR right after :) Thanks !

rzo1 commented 3 years ago

Shall I rebase the commits or squash it before?

redouane59 commented 3 years ago

Shall I rebase the commits or squash it before?

don't worry it's OK like that. I'll rebase & merge it after the build success :)

Good job !

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

rzo1 commented 3 years ago

👍