redouane59 / twittered

Twitter API client for Java developers
Apache License 2.0
237 stars 65 forks source link

Switches codebase to ASL 2.0 license #276

Closed rzo1 closed 3 years ago

rzo1 commented 3 years ago

What does this PR do?

redouane59 commented 3 years ago

Is it mandatory to add on each file the big header of comments ?

rzo1 commented 3 years ago

Is it mandatory to add on each file the big header of comments ?

Yup (afaik it would be the same for the GPL ...) - at least, it is automatically generated...

redouane59 commented 3 years ago

Just found that there

In short, you don't need to put the license in each file. I think it's overkill. 
There's no extra legal protection in doing so. 
It does help a downstream user somewhat, but not by much.

I think the tradition of lots of comment-based metadata (license, creation date of each function, changelog, etc.) 
are very old traditions which exist because they are easy to do and which more a talisman than useful.

Just to keep lighter files I would prefer to avoid adding so much lines and just keep the main license :)

Thanks !

rzo1 commented 3 years ago

No problem. Changed it :)

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

redouane59 commented 3 years ago

Perfect thanks. I'm going to release the version 2.7 tonight.