search

redouane59 / twittered

Twitter API client for Java developers
Apache License 2.0
237 stars 65 forks source link

Adds a FilteredStreamRulePredicate to build syntactically correct stream rules #279

Closed rzo1 closed 3 years ago

rzo1 commented 3 years ago

What does this PR do?

We want to add complex queries to the Filtered Stream Rules API within our application.

Before doing this in our software itself, I thought it would be neat to have a building mechanism inside the actual Twitter library.

Might need some more love regarding documentation and additional checks, but it can be considered as a draft open for discussion.

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

96.6% 96.6% Coverage
0.0% 0.0% Duplication

redouane59 commented 3 years ago

Wow Really interesting ! I never had this idea before. The job is awesome. Confirm me it's finished and I'll merge it :)

rzo1 commented 3 years ago

If you are ok with incremental steps (regarding documentation) and some enhancement checks (for example mi and km checks for the radius string, etc.) in the near future, it can be merged. I will then do a follow up in the next weeks :)

redouane59 commented 3 years ago

Yes the javadoc is there and the implementation looks really clear. Thanks :)