search

redouane59 / twittered

Twitter API client for Java developers
Apache License 2.0
236 stars 64 forks source link

v2.13 #329

Closed redouane59 closed 2 years ago

redouane59 commented 2 years ago
steebchen commented 2 years ago

I'd appreciate if this would get merged and published soon, otherwise the OAuth flow is broken because of #328. Thanks for fixing this though!

redouane59 commented 2 years ago

I'd appreciate if this would get merged and published soon, otherwise the OAuth flow is broken because of #328. Thanks for fixing this though!

Hey @steebchen , I would like to wait for @PhantomYdn to solve https://github.com/redouane59/twittered/issues/326 before releasing this new version. But if during this week-end he doesn't have time to implement it, I will release this version without the feature.

steebchen commented 2 years ago

Maybe would make more sense to release now with the fix and then put #326 into the next version. That's just my 2 cents though, don't want to infere too much with your planning. I'd just appreciate if I can upgrade to the newer version to the bugfix for oauth :)

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 17 Code Smells

14.3% 14.3% Coverage
0.0% 0.0% Duplication

redouane59 commented 2 years ago

Maybe would make more sense to release now with the fix and then put #326 into the next version. That's just my 2 cents though, don't want to infere too much with your planning. I'd just appreciate if I can upgrade to the newer version to the bugfix for oauth :)

Done :)

steebchen commented 2 years ago

Thanks so much! This helps us a lot in our project :) Also confirmed that the oauth issue is indeed fixed now, works as intended.

redouane59 commented 2 years ago

You're welcome !