search

redouane59 / twittered

Twitter API client for Java developers
Apache License 2.0
236 stars 64 forks source link

feat: add user timelines missing fields #341

Closed redouane59 closed 2 years ago

redouane59 commented 2 years ago

fixing https://github.com/redouane59/twittered/issues/340

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

jormungander commented 2 years ago

I think ALL_EXPANSIONS needs to include geo.place_id in order for the places to get added to the includes structure.

redouane59 commented 2 years ago

Hey @jormungander . Really ? Adding it to ALL_PLACE_FIELDS is not enough ?

jormungander commented 2 years ago

Yes. The ALL_PLACE_FIELDS in place.fields tells it which fields to include, but it's the presence of the geo.place_id in expansions which tells Twitter's API whether to put those fields in the includes or not, basically an on/off switch. I've verified this with the API collection Twitter provides for Postman.

redouane59 commented 2 years ago

Thanks, it is fixed and will be available on the next release : https://github.com/redouane59/twittered/pull/352

jormungander commented 2 years ago

I just got around to checking this and I see there's more to it. The Includes class that the TweetList uses (which comes from TweetV2) does not contain a List to put the places data that it's receiving.

redouane59 commented 2 years ago

Could you please submit a pull request @jormungander ? edit : just did it.