redouane59 / twittered

Twitter API client for Java developers
Apache License 2.0
235 stars 64 forks source link

Add list tweets endpoint #399

Closed blizniukov closed 1 year ago

redouane59 commented 1 year ago

Can you remove the indentation changes please ? Or use the project code style ?

redouane59 commented 1 year ago

Don't you think it's better to call the method like the other one with only one argument getTweets ?

  /**
   * Get a tweet list from their id calling https://api.twitter.com/2/tweets
   *
   * @param tweetIds the ids of the tweets
   * @return a tweet object list
   */
  TweetList getTweets(List<String> tweetIds);
blizniukov commented 1 year ago

Can you remove the indentation changes please ? Or use the project code style ?

Done

Don't you think it's better to call the method as the other one with only one argument getTweets ?

  /**
   * Get a tweet list from their id calling https://api.twitter.com/2/tweets
   *
   * @param tweetIds the ids of the tweets
   * @return a tweet object list
   */
  TweetList getTweets(List<String> tweetIds);

It depends on usage. As for me, nice to have both. Onw method without AdditionalParameters and one with them. Because you may need the maximum number parameter.

I can create another one or edit existing.

redouane59 commented 1 year ago

Let me one second to review it deeper, maybe I was wrong and the endpoint you call is not exacting the same one.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 21 Code Smells

5.9% 5.9% Coverage
0.0% 0.0% Duplication