search

redouane59 / twittered

Twitter API client for Java developers
Apache License 2.0
234 stars 64 forks source link

Use try with resources, improve logging #401

Closed blizniukov closed 1 year ago

redouane59 commented 1 year ago

Hey, globally, why should we use brackets instead of variable in message ? Is it a good practice ?

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

blizniukov commented 1 year ago

Hey, globally, why should we use brackets instead of variable in message ? Is it a good practice ?

If short - yes. It is good practice. https://sonarcloud.io/organizations/default/rules?open=java%3AS2629&q=S2629

Here is link to sonarcloud, where more info about this. If you accept, then i will edit all log statements.

I also have some ideas:)

redouane59 commented 1 year ago

Awesome, thanks for the source. Yes don't hesitate, this project is opensource so feel free to improve whatever you want :)