search

redouane59 / twittered

Twitter API client for Java developers
Apache License 2.0
239 stars 66 forks source link

feat: add support for chunked uploading #448

Closed stephenc closed 1 year ago

stephenc commented 1 year ago

tested manually with GIF images, but no automated tests in this

I hereby declare that this contribution is licensed under Apache License Version 2

@redouane59 feel free to rework however you need. Should fix #183 and #281 but is hacky and not my best code

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 46 Code Smells

1.5% 1.5% Coverage
0.0% 0.0% Duplication

redouane59 commented 1 year ago

Hello, Thanks ! Can you just correct the little bug that sonar shows ?

stephenc commented 1 year ago

@redouane59 feel free to rework however you need

Just driving by my friend. But getting a release that can let me tweet gifs would be much appreciated, do whatever you want with the PR

stephenc commented 1 year ago

To clarify, I don’t have the headspace to determine what the idiomatic way of handling the interrupted exception is in your library. Probably quicker if you just push the way you want it on top. This PR should allow edits from maintainers, and I am happy for you to align the code with your style