redpanda-ai / meerkat_webservice_schema

meerkat_webservice_schema
0 stars 0 forks source link

Meerkat response : Country code coming in small letters #31

Open rkumar9 opened 9 years ago

rkumar9 commented 9 years ago

Discription : 99 RANCH #1792 00004EDMONDS 60379344 4256701899 SAFEWAY STORE 18BOTHELL GROCERY STORE

Response:- { "status":"success", "data":{ "cobrand_id":99, "user_id":8235434, "container":"bank", "transaction_list":[ { "store_id":"99 #99 099", "state":"AZ", "street":"5715 W Bell Rd", "city":"Glendale", "ledger_entry":"credit", "source":"FACTUAL", "category_labels":[ "Retail", "Furniture and Decor" ], "country":"us", "match_found":true, "txn_type":"Payment", "source_merchant_id":"3791963c-2c96-4750-b2cf-110373f15738", "merchant_name":"Anna's Linens", "is_physical_merchant":true, "txn_sub_type":"Purchase With Credit Card", "postal_code":"85308", "transaction_id":25454 }, { "store_id":"", "state":"KY", "street":"2001 Ky 1809", "city":"Bryants Store", "ledger_entry":"debit", "source":"FACTUAL", "category_labels":[ "Retail", "Supermarkets and Groceries" ], "country":"us", "match_found":true, "txn_type":"Purchase", "source_merchant_id":"3342e051-47f7-4653-a17b-3b4f04919b4d", "merchant_name":"Adams Grocery", "is_physical_merchant":true, "txn_sub_type":"Purchase With Credit Card", "postal_code":"40921", "transaction_id":863473 } ] } }

redpanda-ai commented 9 years ago

Sorry, we cannot call this a bug. You are the first person to ever state that Country Codes need to be capitalized. If you need this capitalized we might be able to provide it, but reserve use of the the "bug" tag for actual problems with our web service.
Please answer the following questions:

  1. Do you really need this capitalized?
  2. Do we want to make this the standard for all country codes coming out of the Meerkat web service?
kunalmaheshwari commented 9 years ago

@joeandrewkey No issues in calling this an enhancement. Checked in Factual site as well. Looks like they also have country code in small letters. but ideally we should be returning data in ISO format ie CAPS. Anyways right now we work only with US only data. http://data.okfn.org/data/core/country-list